-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Boost build failure on Windows when not able to find MSVC toolset #5099
Fix for Boost build failure on Windows when not able to find MSVC toolset #5099
Conversation
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Looks like my suggestion from #4149 (comment) Can you please add "closes #4149" in the opening comment 🙏 and please link the issue you already noted https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
Will do, no problem. Thanks for approving! |
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 Boost is very massive and some days it's harder to get a build to pass |
Close/Re-open to trigger CI |
Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Again... One more restart is needed 🤞 |
Oh man, at least it's morning here so I can restart this thing the whole day. |
All green in build 7 (
|
@prince-chrismc All passed, but since I'm not authorized to merge I have to wait for more reviewers or you can merge if you have permissions to do it. |
Sadly no one has permission =) https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed ... The the evil bots taking over the world 🤖 My bot picked it up and ur PR is "ready for review" prince-chrismc/conan-center-index-pending-review#1 |
👋 This is a 4 line diff... please take a look 🙏 @SSE4 If you see this, prince-chrismc/conan-center-index-pending-review#1 has more "going stale" but good PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I am really really tentative to approve that... it's just 4 lines diff, but situation isn't trivial, as I've said already, it might be fixing one thing, but breaking another thing (see #3362 (comment)). it might be possible there is no way to make it working correctly for everyone, in the end. but as several people reported it improves workflows for them, let's merge it.
💯 agreed In your comment #3362 (comment), most people expecting it be multiple arguments are UNIX consumers... When using MSVC you typically expect it to be quoted (since it's picked up by default with spaces) I hope this will keep both user bases happy 🤞 |
…to find MSVC toolset
…to find MSVC toolset
Specify library name and version: boost/1.74.0
Closes #4338
Closes #4149
conan-center hook activated.